Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree: fix right-clicking tree nodes bug #12801

Merged
merged 11 commits into from
Aug 17, 2023
Merged

tree: fix right-clicking tree nodes bug #12801

merged 11 commits into from
Aug 17, 2023

Conversation

vladarama
Copy link
Contributor

What it does

Fixes: #12800

This PR fixes the small regression induced by #12783 where right-clicking a tree node would open it.

How to test

  1. Open Theia.
  2. Go to the Explorer view and open a folder.
  3. Right-click on a tree node to open the context menu.
  4. The selected file should not be opened.
  5. Middle-clicking to open tree nodes should still be functional.

Review checklist

Reminder for reviewers

vince-fugnitto
vince-fugnitto approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the bug, and that the changes fixes it successfully.

@vince-fugnitto vince-fugnitto added tree issues related to the tree (ex: tree widget) bug bugs found in the application labels Aug 7, 2023
@vince-fugnitto vince-fugnitto merged commit bc97676 into eclipse-theia:master Aug 17, 2023
6 checks passed
@vladarama vladarama deleted the middle-click branch August 21, 2023 19:47
@vince-fugnitto vince-fugnitto added this to the 1.41.0 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
bug bugs found in the application tree issues related to the tree (ex: tree widget)
Projects
PR Backlog
Archived in project
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.

tree: right-clicking tree nodes opens them
2 participants
@vladarama @vince-fugnitto